Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 14178010: Change libraries map to use Uri. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Test updated Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/tests/vm/dart/isolate_mirror_local_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 8b6775c6b4bc6e9290c6cd2595c1a4c160181773..614e558920c3c7876a175f642997abcdd5f7d309 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -62,14 +62,21 @@ String _makeSignatureString(TypeMirror returnType,
return buf.toString();
}
-class _LocalMirrorSystemImpl implements MirrorSystem {
- // TODO(ahe): [libraries] should be Map<Uri, LibraryMirror>.
+Map<Uri, LibraryMirror> _createLibrariesMap(Map<String, LibraryMirror> map) {
+ var result = new Map<Uri, LibraryMirror>();
+ map.forEach((String url, LibraryMirror mirror) {
+ result[Uri.parse(url)] = mirror;
+ });
+ return result;
+}
+
+class _LocalMirrorSystemImpl extends MirrorSystem {
// Change parameter back to "this.libraries" when native code is changed.
_LocalMirrorSystemImpl(Map<String, LibraryMirror> libraries, this.isolate)
- : _functionTypes = new Map<String, FunctionTypeMirror>(),
- this.libraries = _convertStringToSymbolMap(libraries);
+ : this.libraries = _createLibrariesMap(libraries),
+ _functionTypes = new Map<String, FunctionTypeMirror>();
- final Map<Symbol, LibraryMirror> libraries;
+ final Map<Uri, LibraryMirror> libraries;
final IsolateMirror isolate;
TypeMirror _dynamicType = null;
@@ -401,12 +408,11 @@ class _LocalClosureMirrorImpl extends _LocalInstanceMirrorImpl
}
class _LazyTypeMirror {
- _LazyTypeMirror(String libraryName, String typeName)
- : this.libraryName = _s(libraryName),
- this.typeName = _s(typeName);
+ _LazyTypeMirror(String this.libraryUrl, String typeName)
+ : this.typeName = _s(typeName);
TypeMirror resolve(MirrorSystem mirrors) {
- if (libraryName == null) {
+ if (libraryUrl == null) {
if (typeName == const Symbol('dynamic')) {
return mirrors.dynamicType;
} else if (typeName == const Symbol('void')) {
@@ -416,7 +422,7 @@ class _LazyTypeMirror {
"Mirror for type '$typeName' is not implemented");
}
}
- var resolved = mirrors.libraries[libraryName].members[typeName];
+ var resolved = mirrors.libraries[Uri.parse(libraryUrl)].members[typeName];
if (resolved == null) {
throw new UnimplementedError(
"Mirror for type '$typeName' is not implemented");
@@ -424,7 +430,7 @@ class _LazyTypeMirror {
return resolved;
}
- final Symbol libraryName;
+ final String libraryUrl;
final Symbol typeName;
}
@@ -758,14 +764,13 @@ class _LocalTypedefMirrorImpl extends _LocalMirrorImpl
class _LazyLibraryMirror {
- _LazyLibraryMirror(String libraryName)
- : this.libraryName = _s(libraryName);
+ _LazyLibraryMirror(String this.libraryUrl);
LibraryMirror resolve(MirrorSystem mirrors) {
- return mirrors.libraries[libraryName];
+ return mirrors.libraries[Uri.parse(libraryUrl)];
}
- final Symbol libraryName;
+ final String libraryUrl;
}
class _LocalLibraryMirrorImpl extends _LocalObjectMirrorImpl
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/tests/vm/dart/isolate_mirror_local_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698