Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 141653003: Redo "Make dart2js typed_data implementation classes private" (Closed)

Created:
6 years, 11 months ago by sra1
Modified:
6 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Redo "Make dart2js typed_data implementation classes private" This time with analyzer suppression for new library/ BUG= Committed: https://code.google.com/p/dart/source/detail?r=31935

Patch Set 1 #

Patch Set 2 : suppress analysis errors of dart2js library #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1186 lines, -665 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +10 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 2 chunks +7 lines, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/html/html_common/conversions.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/html/html_common/html_common_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
A sdk/lib/typed_data/dart2js/native_typed_data_dart2js.dart View 1 chunk +970 lines, -0 lines 0 comments Download
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 49 chunks +130 lines, -619 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +16 lines, -0 lines 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 4 chunks +17 lines, -15 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
6 years, 11 months ago (2014-01-17 23:00:52 UTC) #1
sra1
6 years, 11 months ago (2014-01-17 23:01:40 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 manually as r31935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698