sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart - Issue 141653003: Redo "Make dart2js typed_data implementation classes private"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

Issue 141653003: Redo "Make dart2js typed_data implementation classes private" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: suppress analysis errors of dart2js library Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/elements/elements.dart ('k') | sdk/lib/_internal/compiler/implementation/native_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart b/sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

index b54ae28c0967fabc99e66163b3a10574b37d50c8..34c9c02211c16aa226ac06369a44b5d947a28ab5 100644

--- a/sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

+++ b/sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart

@@ -977,11 +977,13 @@ class SimpleTypeInferrerVisitor<T>

elementType, length));

} else if (Elements.isConstructorOfTypedArraySubclass(element, compiler)) {

int length = findLength(node);

+ FunctionElement constructor = element;

+ constructor = constructor.redirectionTarget;

T elementType = inferrer.returnTypeOfElement(

- element.getEnclosingClass().lookupMember('[]'));

+ constructor.getEnclosingClass().lookupMember('[]'));

return inferrer.concreteTypes.putIfAbsent(

node, () => types.allocateList(

- types.nonNullExact(element.getEnclosingClass()), node,

+ types.nonNullExact(constructor.getEnclosingClass()), node,

outermostElement, elementType, length));

} else if (element.isFunction() || element.isConstructor()) {

return returnType;