Issue 14107006: Update Function.apply to use Symbol.

Issue 14107006: Update Function.apply to use Symbol. (Closed)

Created:
7 years, 8 months ago by ahe

Modified:
7 years, 8 months ago

Reviewers:
erikcorry, ngeoffray, kasperl

CC:
reviews_dartlang.org, gbracha, Lasse Reichstein Nielsen, erikcorry

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update Function.apply to use Symbol. Committed: https://code.google.com/p/dart/source/detail?r=21451

Patch Set 2 : Address review comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -10 lines)			Patch
M	dart/runtime/lib/function_patch.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart	View		1 chunk	+12 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/sdk/lib/core/function.dart	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
M	dart/tests/corelib/apply2_test.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	dart/tests/corelib/apply_test.dart	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
A	dart/tests/corelib/symbol_map_helper.dart	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/14107006/diff/7001/dart/runtime/lib/function_patch.dart File dart/runtime/lib/function_patch.dart (right): https://codereview.chromium.org/14107006/diff/7001/dart/runtime/lib/function_patch.dart#newcode23 dart/runtime/lib/function_patch.dart:23: namedArguments.forEach((name, value) { name -> symbol?

7 years, 8 months ago (2013-04-12 12:50:35 UTC) #3

erikcorry

LGTM https://codereview.chromium.org/14107006/diff/7001/dart/sdk/lib/core/function.dart File dart/sdk/lib/core/function.dart (right): https://codereview.chromium.org/14107006/diff/7001/dart/sdk/lib/core/function.dart#newcode25 dart/sdk/lib/core/function.dart:25: * exactly the same result as [: foo(1, ...

7 years, 8 months ago (2013-04-15 12:59:28 UTC) #4

ahe

Thank you for taking a look. https://codereview.chromium.org/14107006/diff/7001/dart/sdk/lib/core/function.dart File dart/sdk/lib/core/function.dart (right): https://codereview.chromium.org/14107006/diff/7001/dart/sdk/lib/core/function.dart#newcode25 dart/sdk/lib/core/function.dart:25: * exactly the ...

7 years, 8 months ago (2013-04-15 13:16:37 UTC) #5

ahe

7 years, 8 months ago (2013-04-15 13:48:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r21451 (presubmit successful).

Expand Messages | Collapse Messages