Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: dart/runtime/lib/function_patch.dart

Issue 14107006: Update Function.apply to use Symbol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/runtime/lib/function_patch.dart
diff --git a/dart/runtime/lib/function_patch.dart b/dart/runtime/lib/function_patch.dart
index 56b817dada646d2dd478ea2caebbc8c1aa264c47..fa2852ab62e147cc9da860d85d95d76185fde047 100644
--- a/dart/runtime/lib/function_patch.dart
+++ b/dart/runtime/lib/function_patch.dart
@@ -8,7 +8,7 @@ patch class Function {
/* patch */ static apply(Function function,
List positionalArguments,
- [Map<String,dynamic> namedArguments]) {
+ [Map<Symbol, dynamic> namedArguments]) {
int numPositionalArguments = 1 + // Function is first implicit argument.
(positionalArguments != null ? positionalArguments.length : 0);
int numNamedArguments = namedArguments != null ? namedArguments.length : 0;
@@ -22,7 +22,7 @@ patch class Function {
if (numNamedArguments > 0) {
namedArguments.forEach((name, value) {
arguments[argumentIndex++] = value;
- names[nameIndex++] = name;
+ names[nameIndex++] = name._name;
});
}
return _apply(arguments, names);
« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698