Issue 140743010: Get rid of dynamic call debug stub

Issue 140743010: Get rid of dynamic call debug stub (Closed)

Created:
6 years, 11 months ago by hausner

Modified:
6 years, 11 months ago

Reviewers:
zra, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Get rid of dynamic call debug stub This leaves only one debugger stub function. Yay. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31932

Patch Set 1 #

Total comments: 4

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -184 lines)			Patch
M	runtime/vm/assembler_x64.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	runtime/vm/code_generator.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/debugger_arm.cc	View	2 chunks	+2 lines, -14 lines	2 comments	Download
M	runtime/vm/debugger_ia32.cc	View	2 chunks	+2 lines, -14 lines	2 comments	Download
M	runtime/vm/debugger_mips.cc	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	runtime/vm/debugger_x64.cc	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 chunk	+0 lines, -28 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hausner

Committed patchset #1 manually as r31932 (presubmit successful).

6 years, 11 months ago (2014-01-17 21:33:07 UTC) #3

zra

6 years, 11 months ago (2014-01-24 16:09:17 UTC) #5

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/140743010/diff/1/runtime/vm/debugger_arm.cc
File runtime/vm/debugger_arm.cc (right):

https://codereview.chromium.org/140743010/diff/1/runtime/vm/debugger_arm.cc#n...
runtime/vm/debugger_arm.cc:50:
Code::Handle(Function::Handle(function_).unoptimized_code());
Same here.

https://codereview.chromium.org/140743010/diff/1/runtime/vm/debugger_arm.cc#n...
runtime/vm/debugger_arm.cc:72:
Code::Handle(Function::Handle(function_).unoptimized_code());
And here.

https://codereview.chromium.org/140743010/diff/1/runtime/vm/debugger_ia32.cc
File runtime/vm/debugger_ia32.cc (right):

https://codereview.chromium.org/140743010/diff/1/runtime/vm/debugger_ia32.cc#...
runtime/vm/debugger_ia32.cc:54:
Code::Handle(Function::Handle(function_).unoptimized_code());
In general, unoptimized code can be disconnected from the function and GC'd.
Even if you know there's another reference to the code other than through the
function, it can be good to add an assert that the code is still around, just in
case.

https://codereview.chromium.org/140743010/diff/1/runtime/vm/debugger_ia32.cc#...
runtime/vm/debugger_ia32.cc:76:
Code::Handle(Function::Handle(function_).unoptimized_code());
Here, and etc.

Expand Messages | Collapse Messages