Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/debugger_x64.cc

Issue 140743010: Get rid of dynamic call debug stub (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/debugger_ia32.cc ('K') | « runtime/vm/debugger_mips.cc ('k') | runtime/vm/stub_code.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_x64.cc
===================================================================
--- runtime/vm/debugger_x64.cc (revision 31928)
+++ runtime/vm/debugger_x64.cc (working copy)
@@ -51,16 +51,7 @@
void CodeBreakpoint::PatchCode() {
ASSERT(!is_enabled_);
switch (breakpoint_kind_) {
- case PcDescriptors::kIcCall: {
- int32_t offset = CodePatcher::GetPoolOffsetAt(pc_);
- ASSERT((offset > 0) && ((offset % 8) == 7));
- saved_value_ = static_cast<uword>(offset);
- const int32_t stub_offset =
- InstructionPattern::OffsetFromPPIndex(
- Assembler::kBreakpointDynamicCPIndex);
- CodePatcher::SetPoolOffsetAt(pc_, stub_offset);
- break;
- }
+ case PcDescriptors::kIcCall:
case PcDescriptors::kUnoptStaticCall:
case PcDescriptors::kRuntimeCall:
case PcDescriptors::kClosureCall:
« runtime/vm/debugger_ia32.cc ('K') | « runtime/vm/debugger_mips.cc ('k') | runtime/vm/stub_code.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698