Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 140693003: process docs: fixed grammar (Closed)

Created:
6 years, 11 months ago by kevmoo
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : noop #

Patch Set 4 : more #

Patch Set 5 : whitespace #

Total comments: 8

Patch Set 6 : CR tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M sdk/lib/io/process.dart View 1 2 3 4 5 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
I think this is better. https://code.google.com/p/dart/issues/detail?id=16143 will help as well.
6 years, 11 months ago (2014-01-16 17:37:42 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/140693003/diff/110001/sdk/lib/io/process.dart File sdk/lib/io/process.dart (right): https://codereview.chromium.org/140693003/diff/110001/sdk/lib/io/process.dart#newcode100 sdk/lib/io/process.dart:100: * the exit code will be a negative ...
6 years, 11 months ago (2014-01-16 19:05:03 UTC) #2
kevmoo
Committed patchset #6 manually as r31943 (presubmit successful).
6 years, 11 months ago (2014-01-18 00:54:25 UTC) #3
kevmoo
6 years, 11 months ago (2014-01-18 00:56:56 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/140693003/diff/110001/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/140693003/diff/110001/sdk/lib/io/process.dart...
sdk/lib/io/process.dart:100: * the exit code will be a negative value in the
range [-255..0],
On 2014/01/16 19:05:03, Søren Gjesse wrote:
> 0 should be excluded from the negative range here. If you don't want the open
> interval you should change 0 to -1.

Done.

https://codereview.chromium.org/140693003/diff/110001/sdk/lib/io/process.dart...
sdk/lib/io/process.dart:257: * On Linux and Mac OS, [kill] sends [signal] to the
process. When the process
Since it's referencing the parameter explicitly, I think we're okay here.

https://codereview.chromium.org/140693003/diff/110001/sdk/lib/io/process.dart...
sdk/lib/io/process.dart:258: * terminates as a result of calling [kill], the
value for [exitCode] may be a
On 2014/01/16 19:05:03, Søren Gjesse wrote:
> Writing "the value for" for a future instead of "the future completes with..."
> is OK with me.

Done.

https://codereview.chromium.org/140693003/diff/110001/sdk/lib/io/process.dart...
sdk/lib/io/process.dart:264: * Otherwis the signal could not be sent, usually
meaning that the process is
On 2014/01/16 19:05:03, Søren Gjesse wrote:
> Otherwis -> Otherwise

Done.

Powered by Google App Engine
This is Rietveld 408576698