Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: sdk/lib/io/process.dart

Issue 140693003: process docs: fixed grammar (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: CR tweaks Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/process.dart
diff --git a/sdk/lib/io/process.dart b/sdk/lib/io/process.dart
index a59fc88d8b4e089926c392e8b91dfdbbceb39538..75bd89334c5ef8982bc7ef55bbccc33f09277bc4 100644
--- a/sdk/lib/io/process.dart
+++ b/sdk/lib/io/process.dart
@@ -97,7 +97,7 @@ abstract class Process {
*
* On Linux and Mac a normal exit code will be a positive value in
* the range [0..255]. If the process was terminated due to a signal
- * the exit code will be a negative value in the range [-255..0[,
+ * the exit code will be a negative value in the range [-255..-1],
* where the absolute value of the exit code is the signal
* number. For example, if a process crashes due to a segmentation
* violation the exit code will be -11, as the signal SIGSEGV has the
@@ -254,16 +254,14 @@ abstract class Process {
int get pid;
/**
- * On Windows, [kill] kills the process, ignoring the [signal]
- * flag. On Posix systems, [kill] sends [signal] to the
- * process. Depending on the signal send, it'll have different
- * meanings. When the process terminates as a result of calling
- * [kill], the [exitCode] future is completed with the exit code.
+ * On Linux and Mac OS, [kill] sends [signal] to the process. When the process
+ * terminates as a result of calling [kill], the value for [exitCode] may be a
+ * negative number corresponding to the provided [signal].
*
- * Returns [:true:] if the process is successfully killed (the
- * signal is successfully sent). Returns [:false:] if the process
- * could not be killed (the signal could not be sent). Usually,
- * a [:false:] return value from kill means that the process is
+ * On Windows, [kill] kills the process, ignoring the [signal] flag.
+ *
+ * Returns [:true:] if the signal is successfully sent and process is killed.
+ * Otherwise the signal could not be sent, usually meaning that the process is
* already dead.
*/
bool kill([ProcessSignal signal = ProcessSignal.SIGTERM]);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698