Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 14057010: Re-write _BufferList to keep an internal Uint8List buffer, that will grow on demand. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen
Modified:
7 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Re-write _BufferList to keep an internal Uint8List buffer, that will grow on demand. This eliminates a lot of the performance issues seen with _BufferList. We now do either setRange if it's Uint8List, or a fast iteration for any other list (in case of e.g. CodeUnits). BUG= Committed: https://code.google.com/p/dart/source/detail?r=21679

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -121 lines) Patch
M sdk/lib/io/buffer_list.dart View 1 1 chunk +52 lines, -114 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 8 months ago (2013-04-18 13:11:14 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/14057010/diff/1/sdk/lib/io/buffer_list.dart File sdk/lib/io/buffer_list.dart (right): https://codereview.chromium.org/14057010/diff/1/sdk/lib/io/buffer_list.dart#newcode39 sdk/lib/io/buffer_list.dart:39: // This will give is a liste in ...
7 years, 8 months ago (2013-04-18 13:19:11 UTC) #2
Anders Johnsen
https://codereview.chromium.org/14057010/diff/1/sdk/lib/io/buffer_list.dart File sdk/lib/io/buffer_list.dart (right): https://codereview.chromium.org/14057010/diff/1/sdk/lib/io/buffer_list.dart#newcode39 sdk/lib/io/buffer_list.dart:39: // This will give is a liste in the ...
7 years, 8 months ago (2013-04-18 16:22:07 UTC) #3
Anders Johnsen
7 years, 8 months ago (2013-04-18 16:22:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698