Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 14050010: New analyzer_experimental snapshot. (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer_experimental snapshot. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22134

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4396 lines, -2362 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_junit.dart View 1 chunk +1 line, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/test_support_include.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java View 5 chunks +33 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 2 chunks +13 lines, -3 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 6 chunks +11 lines, -3 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ObjectSemanticProcessor.java View 6 chunks +51 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 2 chunks +47 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 1 chunk +16 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java View 1 chunk +42 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 16 chunks +140 lines, -113 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/constant.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 43 chunks +185 lines, -71 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 43 chunks +1696 lines, -1330 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/error.dart View 26 chunks +89 lines, -39 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/html.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_core.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_junit.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 18 chunks +153 lines, -48 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 68 chunks +788 lines, -222 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/scanner.dart View 6 chunks +17 lines, -17 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/sdk.dart View 2 chunks +10 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/sdk_io.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source.dart View 8 chunks +115 lines, -9 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source_io.dart View 9 chunks +37 lines, -23 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/element_test.dart View 11 chunks +33 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/parser_test.dart View 5 chunks +77 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 68 chunks +812 lines, -456 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/test_support.dart View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 7 months ago (2013-04-29 16:12:48 UTC) #1
Brian Wilkerson
I didn't look at very much of the generated code, but the rest LGTM with ...
7 years, 7 months ago (2013-04-29 16:36:10 UTC) #2
scheglov
7 years, 7 months ago (2013-04-29 17:56:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698