Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14031011: Print the location of duplicated elements. (Closed)

Created:
7 years, 8 months ago by ahe
Modified:
7 years, 6 months ago
Reviewers:
Johnni Winther, gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Print the location of duplicated elements. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=23684

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merged with HEAD #

Patch Set 3 : Improve diagnostics and write test. #

Patch Set 4 : Fix type warnings #

Total comments: 4

Patch Set 5 : Address review comments #

Messages

Total messages: 6 (0 generated)
ahe
https://codereview.chromium.org/14031011/diff/1/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/14031011/diff/1/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode1482 dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:1482: {'text': 'Giladism: you cannot refer to the same element ...
7 years, 8 months ago (2013-04-17 14:56:24 UTC) #1
Johnni Winther
lgtm
7 years, 8 months ago (2013-04-17 18:25:59 UTC) #2
ahe
PTAL, improved diagnostics and added test.
7 years, 6 months ago (2013-06-06 11:40:12 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/14031011/diff/11001/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/14031011/diff/11001/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode401 dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart:401: var importers = importer.importers[element]; Type this variable. https://codereview.chromium.org/14031011/diff/11001/dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart ...
7 years, 6 months ago (2013-06-06 12:28:31 UTC) #4
ahe
Thank you, Johnni! https://codereview.chromium.org/14031011/diff/11001/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/14031011/diff/11001/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode401 dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart:401: var importers = importer.importers[element]; On 2013/06/06 ...
7 years, 6 months ago (2013-06-06 13:56:16 UTC) #5
ahe
7 years, 6 months ago (2013-06-06 13:56:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 manually as r23684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698