Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: dart/sdk/lib/_internal/compiler/implementation/library_loader.dart

Issue 14031011: Print the location of duplicated elements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 /** 7 /**
8 * [CompilerTask] for loading libraries and setting up the import/export scopes. 8 * [CompilerTask] for loading libraries and setting up the import/export scopes.
9 * 9 *
10 * The library loader uses four different kinds of URIs in different parts of 10 * The library loader uses four different kinds of URIs in different parts of
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 compiler.withCurrentElement(element, () { 521 compiler.withCurrentElement(element, () {
522 compiler.reportError(new Identifier(element.position()), 522 compiler.reportError(new Identifier(element.position()),
523 'duplicated import'); 523 'duplicated import');
524 }); 524 });
525 } 525 }
526 }); 526 });
527 } else { 527 } else {
528 importedLibrary.forEachExport((Element element) { 528 importedLibrary.forEachExport((Element element) {
529 compiler.withCurrentElement(element, () { 529 compiler.withCurrentElement(element, () {
530 if (combinatorFilter.exclude(element)) return; 530 if (combinatorFilter.exclude(element)) return;
531 importingLibrary.addImport(element, compiler); 531 importingLibrary.addImport(element, import, compiler);
532 }); 532 });
533 }); 533 });
534 } 534 }
535 } 535 }
536 } 536 }
537 537
538 /** 538 /**
539 * The combinator filter computed from an export tag and the library dependency 539 * The combinator filter computed from an export tag and the library dependency
540 * node for the library that declared the export tag. This represents an edge in 540 * node for the library that declared the export tag. This represents an edge in
541 * the library dependency graph. 541 * the library dependency graph.
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 } 831 }
832 832
833 /** 833 /**
834 * Registers all top-level entities of [library] as starting point for the 834 * Registers all top-level entities of [library] as starting point for the
835 * fixed-point computation of the import/export scopes. 835 * fixed-point computation of the import/export scopes.
836 */ 836 */
837 void registerLibraryExports(LibraryElement library) { 837 void registerLibraryExports(LibraryElement library) {
838 nodeMap[library].registerInitialExports(); 838 nodeMap[library].registerInitialExports();
839 } 839 }
840 } 840 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698