Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 14029016: Remove legacy debugger API function (Closed)

Created:
7 years, 8 months ago by hausner
Modified:
7 years, 8 months ago
Reviewers:
Tom Ball
CC:
reviews_dartlang.org, podivilov1
Visibility:
Public.

Description

Remove legacy debugger API stuff. The removed functions do not appear to be used in Dartium. Committed: https://code.google.com/p/dart/source/detail?r=21305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -208 lines) Patch
M runtime/bin/main.cc View 1 chunk +12 lines, -26 lines 0 comments Download
M runtime/include/dart_debugger_api.h View 3 chunks +3 lines, -54 lines 0 comments Download
M runtime/lib/mirrors.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 6 chunks +4 lines, -85 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 3 chunks +8 lines, -36 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hausner
7 years, 8 months ago (2013-04-11 17:47:41 UTC) #1
hausner
Could you please take a look, Tom?
7 years, 8 months ago (2013-04-11 18:44:53 UTC) #2
Tom Ball
lgtm
7 years, 8 months ago (2013-04-11 18:58:35 UTC) #3
Tom Ball
lgtm
7 years, 8 months ago (2013-04-11 18:58:36 UTC) #4
hausner
Committed patchset #1 manually as r21305 (presubmit successful).
7 years, 8 months ago (2013-04-11 19:26:32 UTC) #5
hausner
7 years, 8 months ago (2013-04-11 19:27:45 UTC) #6
Message was sent while issue was closed.
Thank you!

Powered by Google App Engine
This is Rietveld 408576698