Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: runtime/bin/main.cc

Issue 14029016: Remove legacy debugger API function (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/include/dart_debugger_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
===================================================================
--- runtime/bin/main.cc (revision 21241)
+++ runtime/bin/main.cc (working copy)
@@ -579,34 +579,20 @@
static Dart_Handle SetBreakpoint(const char* breakpoint_at,
Dart_Handle library) {
- Dart_Handle result;
- if (strchr(breakpoint_at, ':')) {
- char* bpt_line = strdup(breakpoint_at);
- char* colon = strchr(bpt_line, ':');
- ASSERT(colon != NULL);
- *colon = '\0';
- Dart_Handle url = DartUtils::NewString(bpt_line);
- Dart_Handle line_number = Dart_NewInteger(atoi(colon + 1));
- free(bpt_line);
- Dart_Breakpoint bpt;
- result = Dart_SetBreakpointAtLine(url, line_number, &bpt);
+ char* bpt_function = strdup(breakpoint_at);
+ Dart_Handle class_name;
+ Dart_Handle function_name;
+ char* dot = strchr(bpt_function, '.');
+ if (dot == NULL) {
+ class_name = DartUtils::NewString("");
+ function_name = DartUtils::NewString(breakpoint_at);
} else {
- char* bpt_function = strdup(breakpoint_at);
- Dart_Handle class_name;
- Dart_Handle function_name;
- char* dot = strchr(bpt_function, '.');
- if (dot == NULL) {
- class_name = DartUtils::NewString("");
- function_name = DartUtils::NewString(breakpoint_at);
- } else {
- *dot = '\0';
- class_name = DartUtils::NewString(bpt_function);
- function_name = DartUtils::NewString(dot + 1);
- }
- free(bpt_function);
- result = Dart_OneTimeBreakAtEntry(library, class_name, function_name);
+ *dot = '\0';
+ class_name = DartUtils::NewString(bpt_function);
+ function_name = DartUtils::NewString(dot + 1);
}
- return result;
+ free(bpt_function);
+ return Dart_OneTimeBreakAtEntry(library, class_name, function_name);
}
« no previous file with comments | « no previous file | runtime/include/dart_debugger_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698