Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 14023005: Do not allocate unnecessary ObjectArrays. When allocating an empty growable array, pass it just a… (Closed)

Created:
7 years, 8 months ago by srdjan
Modified:
7 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not allocate unnecessary ObjectArrays. When allocating an empty growable array, pass it a compile time constant empty array instead of allocating a new empty array at runtime, since the factory method will anyway allocate its own object array of length 4. Committed: https://code.google.com/p/dart/source/detail?r=21490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M runtime/vm/parser.cc View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
No emails sent... trying again.
7 years, 8 months ago (2013-04-12 23:02:34 UTC) #1
hausner
LGTM.
7 years, 8 months ago (2013-04-15 18:04:09 UTC) #2
srdjan
7 years, 8 months ago (2013-04-15 18:07:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698