Do not allocate unnecessary ObjectArrays. When allocating an empty growable array, pass it just a…

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
@@ skipping 8778 matching lines @@
       ASSERT(factory_type_args.Length() == 1);
       Type& factory_type = Type::Handle(Type::New(
           factory_class, factory_type_args, type_pos, Heap::kNew));
       factory_type ^= ClassFinalizer::FinalizeType(
           current_class(), factory_type, ClassFinalizer::kFinalize);
       factory_type_args = factory_type.arguments();
       ASSERT(factory_type_args.Length() == factory_class.NumTypeArguments());
     }
     factory_type_args = factory_type_args.Canonicalize();
     ArgumentListNode* factory_param = new ArgumentListNode(literal_pos);
-    const LocalVariable& temp_local = *BuildArrayTempLocal(type_pos);
-    ArrayNode* list = new ArrayNode(TokenPos(), type, temp_local, element_list);
-    factory_param->Add(list);
+    if (element_list.length() == 0) {
+      // TODO(srdjan): Use Object::empty_array once issue 9871 has been fixed.
+      Array& empty_array = Array::ZoneHandle(Object::empty_array().raw());
+      LiteralNode* empty_array_literal =
+          new LiteralNode(TokenPos(), empty_array);
+      factory_param->Add(empty_array_literal);
+    } else {
+      const LocalVariable& temp_local = *BuildArrayTempLocal(type_pos);
+      ArrayNode* list =
+          new ArrayNode(TokenPos(), type, temp_local, element_list);
+      factory_param->Add(list);
+    }
     return CreateConstructorCallNode(literal_pos,
                                      factory_type_args,
                                      factory_method,
                                      factory_param);
   }
 }
 
 
 ConstructorCallNode* Parser::CreateConstructorCallNode(
     intptr_t token_pos,
@@ skipping 1108 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart