Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1400743002: Add support for setUpAll and tearDownAll. (Closed)

Created:
5 years, 2 months ago by nweiz
Modified:
5 years, 2 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1278 lines, -102 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/src/backend/declarer.dart View 6 chunks +59 lines, -22 lines 0 comments Download
M lib/src/backend/group.dart View 2 chunks +16 lines, -3 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 2 chunks +20 lines, -5 lines 0 comments Download
M lib/src/runner/browser/iframe_listener.dart View 1 chunk +26 lines, -16 lines 0 comments Download
M lib/src/runner/engine.dart View 4 chunks +42 lines, -16 lines 0 comments Download
M lib/src/runner/loader.dart View 2 chunks +16 lines, -3 lines 0 comments Download
M lib/src/runner/vm/isolate_listener.dart View 1 chunk +23 lines, -15 lines 0 comments Download
M lib/test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
A test/frontend/set_up_all_test.dart View 1 chunk +324 lines, -0 lines 0 comments Download
A test/frontend/tear_down_all_test.dart View 1 chunk +372 lines, -0 lines 0 comments Download
M test/runner/browser/runner_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M test/runner/engine_test.dart View 5 chunks +13 lines, -18 lines 0 comments Download
A test/runner/set_up_all_test.dart View 1 chunk +120 lines, -0 lines 0 comments Download
M test/runner/signal_test.dart View 2 chunks +33 lines, -2 lines 0 comments Download
A test/runner/tear_down_all_test.dart View 1 chunk +120 lines, -0 lines 0 comments Download
M test/utils.dart View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 2 months ago (2015-10-09 01:02:49 UTC) #1
kevmoo
update scheduled_test, otherwise LGTM
5 years, 2 months ago (2015-10-09 16:26:04 UTC) #2
nweiz
5 years, 2 months ago (2015-10-09 20:56:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b263d778052c03876ceb63db3504aa149095c44 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698