Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: test/runner/engine_test.dart

Issue 1400743002: Add support for setUpAll and tearDownAll. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/browser/runner_test.dart ('k') | test/runner/set_up_all_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/engine_test.dart
diff --git a/test/runner/engine_test.dart b/test/runner/engine_test.dart
index bb6a7db8bb7e11fd1d656aef3643959146888809..37d121358a3fe5f02676a40e7d5a2811d5f3d832 100644
--- a/test/runner/engine_test.dart
+++ b/test/runner/engine_test.dart
@@ -57,11 +57,11 @@ void main() {
test("emits each test before it starts running and after the previous test "
"finished", () {
var testsRun = 0;
- var engine = withTests(declare(() {
+ var engine = declareEngine(() {
for (var i = 0; i < 3; i++) {
test("test ${i + 1}", expectAsync(() => testsRun++, max: 1));
}
- }));
+ });
engine.onTestStarted.listen(expectAsync((liveTest) {
// [testsRun] should be one less than the test currently running.
@@ -77,33 +77,33 @@ void main() {
});
test(".run() returns true if every test passes", () {
- var engine = withTests(declare(() {
+ var engine = declareEngine(() {
for (var i = 0; i < 2; i++) {
test("test ${i + 1}", () {});
}
- }));
+ });
expect(engine.run(), completion(isTrue));
});
test(".run() returns false if any test fails", () {
- var engine = withTests(declare(() {
+ var engine = declareEngine(() {
for (var i = 0; i < 2; i++) {
test("test ${i + 1}", () {});
}
test("failure", () => throw new TestFailure("oh no"));
- }));
+ });
expect(engine.run(), completion(isFalse));
});
test(".run() returns false if any test errors", () {
- var engine = withTests(declare(() {
+ var engine = declareEngine(() {
for (var i = 0; i < 2; i++) {
test("test ${i + 1}", () {});
}
test("failure", () => throw "oh no");
- }));
+ });
expect(engine.run(), completion(isFalse));
});
@@ -117,9 +117,9 @@ void main() {
group("for a skipped test", () {
test("doesn't run the test's body", () async {
var bodyRun = false;
- var engine = withTests(declare(() {
+ var engine = declareEngine(() {
test("test", () => bodyRun = true, skip: true);
- }));
+ });
await engine.run();
expect(bodyRun, isFalse);
@@ -130,7 +130,9 @@ void main() {
test("test", () {}, skip: true);
});
- var engine = withTests(tests);
+ var engine = new Engine.withSuites([
+ new RunnerSuite(const VMEnvironment(), new Group.root(tests))
+ ]);
engine.onTestStarted.listen(expectAsync((liveTest) {
expect(liveTest, same(engine.liveTests.single));
@@ -151,10 +153,3 @@ void main() {
});
});
}
-
-/// Returns an engine that will run [tests].
-Engine withTests(List<Test> tests) {
- return new Engine.withSuites([
- new RunnerSuite(const VMEnvironment(), new Group.root(tests))
- ]);
-}
« no previous file with comments | « test/runner/browser/runner_test.dart ('k') | test/runner/set_up_all_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698