Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 139983004: Server code clean-up (Closed)

Created:
6 years, 10 months ago by Brian Wilkerson
Modified:
6 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M pkg/analysis_server/lib/http_server.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/channel.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_context.dart View 4 chunks +8 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Brian Wilkerson
6 years, 10 months ago (2014-02-08 01:07:20 UTC) #1
scheglov
LGTM
6 years, 10 months ago (2014-02-08 01:20:55 UTC) #2
Brian Wilkerson
6 years, 10 months ago (2014-02-08 15:25:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32466 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698