Server code clean-up

pkg/analysis_server/lib/src/domain_context.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library domain.context;
 
+import 'package:analysis_server/src/analysis_server.dart';
+import 'package:analysis_server/src/protocol.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/source.dart';
 
-import 'analysis_server.dart';
-import 'protocol.dart';
-
 /**
  * Instances of the class [ContextDomainHandler] implement a [RequestHandler]
  * that handles requests in the context domain.
  */
 class ContextDomainHandler implements RequestHandler {
   /**
    * The name of the context.applyChanges request.
    */
   static const String APPLY_CHANGES_NAME = 'context.applyChanges';
 
@@ skipping 88 matching lines @@
    * Inform the specified context that the changes encoded in the change set
    * have been made. Any invalidated analysis results will be flushed from the
    * context.
    */
   Response applyChanges(Request request) {
     AnalysisContext context = getAnalysisContext(request);
     Map<String, Object> changesData = request.getRequiredParameter(CHANGES_PARAM);
     ChangeSet changeSet = createChangeSet(changesData);
 
     context.applyChanges(changeSet);
+    Response response = new Response(request.id);
+    return response;
   }
 
   /**
    * Convert the given JSON object into a [ChangeSet].
    */
   ChangeSet createChangeSet(Map<String, Object> jsonData) {
     // TODO(brianwilkerson) Implement this.
     return null;
   }
 
   /**
    * Set the options controlling analysis within a context to the given set of
    * options.
    */
   Response setOptions(Request request) {
     AnalysisContext context = getAnalysisContext(request);
 
     context.analysisOptions = createAnalysisOptions(request);
+    Response response = new Response(request.id);
+    return response;
   }
 
   /**
    * Return the set of analysis options associated with the given [request], or
    * throw a [RequestFailure] exception if the analysis options are not valid.
    */
   AnalysisOptions createAnalysisOptions(Request request) {
     Map<String, Object> optionsData = request.getRequiredParameter(OPTIONS_PARAM);
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     optionsData.forEach((String key, Object value) {
@@ skipping 19 matching lines @@
   /**
    * Set the priority sources in the specified context to the sources in the
    * given array.
    */
   Response setPrioritySources(Request request) {
     AnalysisContext context = getAnalysisContext(request);
     List<String> sourcesData = request.getRequiredParameter(SOURCES_PARAM);
     List<Source> sources = convertToSources(context.sourceFactory, sourcesData);
 
     context.analysisPriorityOrder = sources;
+    Response response = new Response(request.id);
+    return response;
   }
 
   /**
    * Convert the given list of strings into a list of sources owned by the given
    * [sourceFactory].
    */
   List<Source> convertToSources(SourceFactory sourceFactory, List<String> sourcesData) {
     List<Source> sources = new List<Source>();
     sourcesData.forEach((String string) {
       sources.add(sourceFactory.fromEncoding(string));
     });
     return sources;
   }
 
   /**
    * Return the analysis context specified by the given request, or throw a
    * [RequestFailure] exception if either there is no specified context or if
    * the specified context does not exist.
    */
   AnalysisContext getAnalysisContext(Request request) {
     String contextId = request.getRequiredParameter(CONTEXT_ID_PARAM);
     AnalysisContext context = server.contextMap[contextId];
     if (context == null) {
       throw new RequestFailure(new Response.contextDoesNotExist(request));
     }
     return context;
   }
 }