Issue 13963020: Resubmit: "With the collections deriving from ListBase, we no longer need to implement a numbe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13963020: Resubmit: "With the collections deriving from ListBase, we no longer need to implement a numbe… (Closed)

Created:
7 years, 8 months ago by blois

Modified:
7 years, 8 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

This is a resubmit of: https://codereview.chromium.org/13852008/ There were some type issues in Dartium checked mode on collections which caused problems. Basically just tweaked the generic arguments on some collections. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22087

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -1093 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	16 chunks	+16 lines, -333 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		16 chunks	+16 lines, -333 lines	0 comments	Download
M	sdk/lib/html/html_common/filtered_element_list.dart	View	1	5 chunks	+6 lines, -85 lines	0 comments	Download
M	tests/html/element_test.dart	View		4 chunks	+39 lines, -7 lines	0 comments	Download
M	tests/html/node_test.dart	View		2 chunks	+62 lines, -0 lines	0 comments	Download
M	tools/dom/src/WrappedList.dart	View		5 chunks	+1 line, -83 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1	9 chunks	+7 lines, -212 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	1	2 chunks	+8 lines, -38 lines	0 comments	Download

Total messages: 3 (0 generated)

blois

7 years, 8 months ago (2013-04-26 21:10:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22087 (presubmit successful).