Add timestamp to AppCache manifest.

Add timestamp to AppCache manifest.

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31888

[kustermann, 2014-01-16 14:31:37]

LGTM

https://codereview.chromium.org/139513003/diff/50001/dart/site/try/add_time_s...
File dart/site/try/add_time_stamp.py (right):

https://codereview.chromium.org/139513003/diff/50001/dart/site/try/add_time_s...
dart/site/try/add_time_stamp.py:7: import re
"re" is not used, is it?

https://codereview.chromium.org/139513003/diff/50001/dart/site/try/add_time_s...
dart/site/try/add_time_stamp.py:17: timestamp = str(time.time())
If I understand it correctly, the only thing you want to ensure is that the file
changes. If so then:

Instead of seeing a number like:
  '1389882566.257333'
which doesn't say much, you could do e.g.:
  timestamp = str(datetime.datetime.now())
which gives a human understandable:
  '2014-01-16 15:29:08.939314'

https://codereview.chromium.org/139513003/diff/50001/dart/site/try/add_time_s...
dart/site/try/add_time_stamp.py:25: output_file.close()
You could make this a bit more readable:

with open(input_file_name) as input:
  with open(output_file_name, 'w') as output:
    output.write(input.read().replace("@@TIMESTAMP@@', 'timestamp))

[ahe, 2014-01-16 16:03:48]

Thank you, Martin. Great suggestions!

https://codereview.chromium.org/139513003/diff/50001/dart/site/try/add_time_s...
File dart/site/try/add_time_stamp.py (right):

https://codereview.chromium.org/139513003/diff/50001/dart/site/try/add_time_s...
dart/site/try/add_time_stamp.py:7: import re
On 2014/01/16 14:31:37, kustermann wrote:
> "re" is not used, is it?

Done.

https://codereview.chromium.org/139513003/diff/50001/dart/site/try/add_time_s...
dart/site/try/add_time_stamp.py:17: timestamp = str(time.time())
On 2014/01/16 14:31:37, kustermann wrote:
> If I understand it correctly, the only thing you want to ensure is that the
file
> changes. If so then:
> 
> Instead of seeing a number like:
>   '1389882566.257333'
> which doesn't say much, you could do e.g.:
>   timestamp = str(datetime.datetime.now())
> which gives a human understandable:
>   '2014-01-16 15:29:08.939314'
> 

That's actually what I wanted, but I didn't want to spend time reading the
Python documentation to find this method ;-)

https://codereview.chromium.org/139513003/diff/50001/dart/site/try/add_time_s...
dart/site/try/add_time_stamp.py:25: output_file.close()
On 2014/01/16 14:31:37, kustermann wrote:
> You could make this a bit more readable:
> 
> with open(input_file_name) as input:
>   with open(output_file_name, 'w') as output:
>     output.write(input.read().replace("@@TIMESTAMP@@', 'timestamp))

Thank you, I had forgotten about "with". "input" is highlighted as a reserved
word in Emacs' Python mode, so I prefer using input_file.

[ahe, 2014-01-16 16:04:41]

Committed patchset #2 manually as r31888 (presubmit successful).