Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: dart/site/try/build_try.gyp

Issue 139513003: Add timestamp to AppCache manifest. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Implement Martin's suggestions. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/site/try/add_time_stamp.py ('k') | dart/site/try/nossl.appcache » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/site/try/build_try.gyp
diff --git a/dart/site/try/build_try.gyp b/dart/site/try/build_try.gyp
index 09fec19872067169c7a57f95e0a3d5c79e744525..c966ce1f75403ec39cdeb9009abf301de8849616 100644
--- a/dart/site/try/build_try.gyp
+++ b/dart/site/try/build_try.gyp
@@ -12,6 +12,24 @@
# Concern: there should really be a dependency on
# ../../dart.gyp:create_sdk, but this is reported as a cycle by GYP.
],
+ 'variables': {
+ 'try_dart_static_files': [
+ 'index.html',
+ 'dartlang-style.css',
+ 'iframe.html',
+ 'iframe.js',
+ 'dart-icon.png',
+ 'dart-iphone5.png',
+
+ '../../third_party/font-awesome/font-awesome-4.0.3/'
+ 'fonts/fontawesome-webfont.woff',
+
+ '../../sdk/lib/_internal/dartdoc/static/favicon.ico',
+
+ '<(SHARED_INTERMEDIATE_DIR)/leap.dart.js',
+ '<(SHARED_INTERMEDIATE_DIR)/sdk.json',
+ ],
+ },
'actions': [
{
'action_name': 'sdk_json',
@@ -62,6 +80,26 @@
'-o<(SHARED_INTERMEDIATE_DIR)/leap.dart.js',
],
},
+ {
+ 'action_name': 'nossl_appcache',
+ 'message': 'Creating nossl.appcache',
+ 'inputs': [
+ 'add_time_stamp.py',
+ 'nossl.appcache',
+ '<@(try_dart_static_files)',
+ ],
+ 'outputs': [
+ '<(SHARED_INTERMEDIATE_DIR)/nossl.appcache',
+ ],
+ # Try Dart! uses AppCache. Cached files are only validated when the
+ # manifest changes (not its timestamp, but its actual contents).
+ 'action': [
+ 'python',
+ 'add_time_stamp.py',
+ 'nossl.appcache',
+ '<(SHARED_INTERMEDIATE_DIR)/nossl.appcache',
+ ],
+ },
],
'copies': [
{
@@ -70,22 +108,8 @@
# List of files to be copied (creates implicit build dependencies).
'files': [
'app.yaml',
-
- 'nossl.appcache',
- 'index.html',
- 'dartlang-style.css',
- 'iframe.html',
- 'iframe.js',
- 'dart-icon.png',
- 'dart-iphone5.png',
-
- '../../third_party/font-awesome/font-awesome-4.0.3/'
- 'fonts/fontawesome-webfont.woff',
-
- '../../sdk/lib/_internal/dartdoc/static/favicon.ico',
-
- '<(SHARED_INTERMEDIATE_DIR)/leap.dart.js',
- '<(SHARED_INTERMEDIATE_DIR)/sdk.json',
+ '<@(try_dart_static_files)',
+ '<(SHARED_INTERMEDIATE_DIR)/nossl.appcache',
],
},
],
« no previous file with comments | « dart/site/try/add_time_stamp.py ('k') | dart/site/try/nossl.appcache » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698