Refactor the code for making inlining decisions.

Refactor the code for making inlining decisions.

Separate the decision to inlin, which produces a graph to inline, from the
act of inlining itself.  For polymorphic inlining we need such a separation.

Change the function that integrates an inlined function graph into a caller
graph so that it operates on a graph entry and set of inlined exits rather
than on an entire flow graph.  Flow graphs represent a whole function so
this change allows us to replace an instruction with an arbitrary subgraph.

Change the name of the InliningContext class to InlineExitCollector to more
accurately reflect what it does.

Committed: https://code.google.com/p/dart/source/detail?r=21539

[Florian Schneider, 2013-04-12 12:08:27]

LGTM.

[Kevin Millikin (Google), 2013-04-16 08:40:39]

Committed patchset #1 manually as r21539 (presubmit successful).

[srdjan, 2013-04-16 16:51:17]

DBC

https://codereview.chromium.org/13932005/diff/1/runtime/vm/flow_graph_inliner.cc
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/13932005/diff/1/runtime/vm/flow_graph_inliner...
runtime/vm/flow_graph_inliner.cc:605: void InlineCall(InlinedCallData*
call_data) {
call_data is read only in this function, you could make it const ref, then the
callers become simpler.

[tfarina, 2013-04-23 02:05:27]

https://codereview.chromium.org/13932005/diff/1/runtime/vm/flow_graph_inliner.cc
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/13932005/diff/1/runtime/vm/flow_graph_inliner...
runtime/vm/flow_graph_inliner.cc:605: void InlineCall(InlinedCallData*
call_data) {
On 2013/04/16 16:51:17, srdjan wrote:
> call_data is read only in this function, you could make it const ref, then the
> callers become simpler.
I have addressed this here: https://codereview.chromium.org/14341013/