Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 13913005: Implement JS version of LinkedHashSet and move the various HashTable implementations to the VM coll… (Closed)

Created:
7 years, 8 months ago by kasperl
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement JS version of LinkedHashSet and move the various HashTable implementations to the VM collection library patch. R=erikcorry@google.com,lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21180

Patch Set 1 #

Total comments: 2

Patch Set 2 : Map -> set. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1083 lines, -712 lines) Patch
M runtime/lib/collection_patch.dart View 3 chunks +699 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart View 1 2 chunks +327 lines, -2 lines 0 comments Download
M sdk/lib/collection/collection.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/collection/collection_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/collection/hash_map.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M sdk/lib/collection/hash_set.dart View 2 chunks +10 lines, -10 lines 0 comments Download
D sdk/lib/collection/hash_table.dart View 1 chunk +0 lines, -404 lines 0 comments Download
M sdk/lib/collection/linked_hash_set.dart View 1 chunk +19 lines, -94 lines 0 comments Download
D sdk/lib/collection/linked_hash_table.dart View 1 chunk +0 lines, -165 lines 0 comments Download
M tests/corelib/hash_set_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kasperl
7 years, 8 months ago (2013-04-09 12:12:23 UTC) #1
erikcorry
There is a lot of moved stuff, which makes it hard to review, but it ...
7 years, 8 months ago (2013-04-09 13:43:35 UTC) #2
kasperl
Committed patchset #2 manually as r21180 (presubmit successful).
7 years, 8 months ago (2013-04-10 07:13:06 UTC) #3
Ivan Posva
7 years, 8 months ago (2013-04-11 00:46:54 UTC) #4
Message was sent while issue was closed.
In the future please include somebody from the VM team when you are changing
implementation in runtime/.

That way we at least have a chance to know what is happening in our code.

Thanks,
-Ivan

Powered by Google App Engine
This is Rietveld 408576698