Implement JS version of LinkedHashSet and move the various HashTable implementations to the VM coll…

Implement JS version of LinkedHashSet and move the various HashTable implementations to the VM collection library patch.


R=erikcorry@google.com,lrn@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21180

[erikcorry, 2013-04-09 13:43:35]

There is a lot of moved stuff, which makes it hard to review, but it LGTM

https://codereview.chromium.org/13913005/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart
(right):

https://codereview.chromium.org/13913005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart:1018: // be
able to throw when the map is modified while being iterated
map->set

https://codereview.chromium.org/13913005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart:1140:
_filterWhere(test, false);
This removes the elements where the test returns false, but the spec says it
will remove those where the test does not return true.

[kasperl, 2013-04-10 07:13:06]

Committed patchset #2 manually as r21180 (presubmit successful).

[Ivan Posva, 2013-04-11 00:46:54]

In the future please include somebody from the VM team when you are changing
implementation in runtime/.

That way we at least have a chance to know what is happening in our code.

Thanks,
-Ivan