Make Suite contain a single Group.

Make Suite contain a single Group.

This is necessary for #18, since the root group may have
setUpAll/tearDownAll metadata that needs to be preserved and shouldn't
be shunted into the Suite.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/ef2a46e32b7d8208ad8b3d9a6b0a8238d06ec939

[kevmoo, 2015-10-07 00:59:52]

I see many calls to create Group(.root) with empty entries. Consider named arg +
handle null?

Also some analysis complaints

/Users/kevmoo/source/github/test.dart/lib/src/runner/load_exception_suite.dart
Warning:(26, 15) The argument type 'List' cannot be assigned to the parameter
type 'Group'
/Users/kevmoo/source/github/test.dart/test/runner/engine_test.dart
Warning:(156, 23) The name 'Test' is not a type and cannot be used as a
parameterized type
Information:(5, 8) Unused import
/Users/kevmoo/source/github/test.dart/test/utils.dart
Warning:(287, 6) The name 'GroupEntry' is not a type and cannot be used as a
parameterized type
/Users/kevmoo/source/github/test.dart/lib/src/runner/browser/iframe_listener.dart
Information:(15, 8) Unused import
/Users/kevmoo/source/github/test.dart/lib/src/runner/vm/isolate_listener.dart
Information:(16, 8) Unused import
/Users/kevmoo/source/github/test.dart/test/backend/declarer_test.dart
Information:(7, 8) Unused import

https://codereview.chromium.org/1390883002/diff/1/lib/src/backend/group.dart
File lib/src/backend/group.dart (right):

https://codereview.chromium.org/1390883002/diff/1/lib/src/backend/group.dart#...
lib/src/backend/group.dart:31: : entries = new
UnmodifiableListView<GroupEntry>(entries.toList()),
using new List.unmodifiable(..) instead?

Copies elements if needed. Handles already unmodifiable inputs, etc.

Added in 1.11

https://api.dartlang.org/1.12.1/dart-core/List/List.unmodifiable.html

https://codereview.chromium.org/1390883002/diff/1/test/runner/engine_test.dart
File test/runner/engine_test.dart (right):

https://codereview.chromium.org/1390883002/diff/1/test/runner/engine_test.dar...
test/runner/engine_test.dart:5: import 'package:test/src/backend/declarer.dart';
unused import

https://codereview.chromium.org/1390883002/diff/1/test/runner/engine_test.dar...
test/runner/engine_test.dart:156: Engine withTests(List<Test> tests) {
Test is not defined? Missing import?

[nweiz, 2015-10-07 19:20:20]

Code review changes

[nweiz, 2015-10-07 19:22:18]

> I see many calls to create Group(.root) with empty entries.
> Consider named arg + handle null?

A little under half of our groups take an empty entries list, and having it be
required makes it clear that the entries are an important part of what defines a
group. I'd like to leave it as-is.

https://codereview.chromium.org/1390883002/diff/1/lib/src/backend/group.dart
File lib/src/backend/group.dart (right):

https://codereview.chromium.org/1390883002/diff/1/lib/src/backend/group.dart#...
lib/src/backend/group.dart:31: : entries = new
UnmodifiableListView<GroupEntry>(entries.toList()),
On 2015/10/07 00:59:51, kevmoo wrote:
> using new List.unmodifiable(..) instead?
> 
> Copies elements if needed. Handles already unmodifiable inputs, etc.
> 
> Added in 1.11
> 
> https://api.dartlang.org/1.12.1/dart-core/List/List.unmodifiable.html

Done.

https://codereview.chromium.org/1390883002/diff/1/test/runner/engine_test.dart
File test/runner/engine_test.dart (right):

https://codereview.chromium.org/1390883002/diff/1/test/runner/engine_test.dar...
test/runner/engine_test.dart:5: import 'package:test/src/backend/declarer.dart';
On 2015/10/07 00:59:51, kevmoo wrote:
> unused import

Done.

[kevmoo, 2015-10-07 19:24:45]

lgtm

https://codereview.chromium.org/1390883002/diff/20001/lib/src/runner/load_exc...
File lib/src/runner/load_exception_suite.dart (right):

https://codereview.chromium.org/1390883002/diff/20001/lib/src/runner/load_exc...
lib/src/runner/load_exception_suite.dart:26: super(new Group.root([
missing import for Group

[nweiz, 2015-10-07 21:48:57]

Code review changes

[nweiz, 2015-10-07 21:49:02]

https://codereview.chromium.org/1390883002/diff/20001/lib/src/runner/load_exc...
File lib/src/runner/load_exception_suite.dart (right):

https://codereview.chromium.org/1390883002/diff/20001/lib/src/runner/load_exc...
lib/src/runner/load_exception_suite.dart:26: super(new Group.root([
On 2015/10/07 19:24:45, kevmoo wrote:
> missing import for Group

Done.

[nweiz, 2015-10-07 21:49:17]

Committed patchset #3 (id:40001) manually as
ef2a46e32b7d8208ad8b3d9a6b0a8238d06ec939 (presubmit successful).