Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: lib/src/backend/group_entry.dart

Issue 1390883002: Make Suite contain a single Group. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/backend/group.dart ('k') | lib/src/backend/suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/backend/group_entry.dart
diff --git a/lib/src/backend/suite_entry.dart b/lib/src/backend/group_entry.dart
similarity index 74%
rename from lib/src/backend/suite_entry.dart
rename to lib/src/backend/group_entry.dart
index f7ace1903a0e9250b3d44a57ae6eb26462477c3b..087944d20ae002ccf6d255f24d0ca241a64d6e7c 100644
--- a/lib/src/backend/suite_entry.dart
+++ b/lib/src/backend/group_entry.dart
@@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library test.backend.test_or_group;
+library test.backend.group_entry;
import 'metadata.dart';
import 'operating_system.dart';
@@ -10,12 +10,15 @@ import 'test.dart';
import 'test_platform.dart';
/// A [Test] or [Group].
-abstract class SuiteEntry {
- /// The name of the entry, includes the prefixes from any containing [Group]s.
+abstract class GroupEntry {
+ /// The name of the entry, including the prefixes from any containing
+ /// [Group]s.
+ ///
+ /// This will be `null` for the root group.
String get name;
/// The metadata for the entry, including the metadata from any containing
- /// [Group]s and the test suite.
+ /// [Group]s.
Metadata get metadata;
/// Returns a copy of [this] with all platform-specific metadata resolved.
@@ -23,12 +26,12 @@ abstract class SuiteEntry {
/// Removes any tests and groups with [Metadata.testOn] selectors that don't
/// match [platform] and [selector]. Returns `null` if this entry's selector
/// doesn't match.
- SuiteEntry forPlatform(TestPlatform platform, {OperatingSystem os});
+ GroupEntry forPlatform(TestPlatform platform, {OperatingSystem os});
/// Returns a copy of [this] with all tests that don't match [callback]
/// removed.
///
/// Returns `null` if this is a test that doesn't match [callback] or a group
/// where no child tests match [callback].
- SuiteEntry filter(bool callback(Test test));
+ GroupEntry filter(bool callback(Test test));
}
« no previous file with comments | « lib/src/backend/group.dart ('k') | lib/src/backend/suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698