Issue 13884009: Support IfThenElse instruction pattern for arbitrary smi constants.

Issue 13884009: Support IfThenElse instruction pattern for arbitrary smi constants. (Closed)

Created:
7 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 8 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support IfThenElse instruction pattern for arbitrary smi constants. Also fix bug in the IfThenElse::Canonicalize. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21364

Patch Set 2 : #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -38 lines)			Patch
M	runtime/vm/intermediate_language.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	3 chunks	+24 lines, -19 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	3 chunks	+23 lines, -18 lines	0 comments	Download
M	tests/language/if_conversion_vm_test.dart	View		3 chunks	+10 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Still LGTM. https://codereview.chromium.org/13884009/diff/4001/tests/language/if_conversion_vm_test.dart File tests/language/if_conversion_vm_test.dart (right): https://codereview.chromium.org/13884009/diff/4001/tests/language/if_conversion_vm_test.dart#newcode27 tests/language/if_conversion_vm_test.dart:27: f16(i) => !identical(i, null) ? 2 : ...

7 years, 8 months ago (2013-04-12 15:18:52 UTC) #3

Vyacheslav Egorov (Google)

https://codereview.chromium.org/13884009/diff/4001/tests/language/if_conversion_vm_test.dart File tests/language/if_conversion_vm_test.dart (right): https://codereview.chromium.org/13884009/diff/4001/tests/language/if_conversion_vm_test.dart#newcode27 tests/language/if_conversion_vm_test.dart:27: f16(i) => !identical(i, null) ? 2 : 3; On ...

7 years, 8 months ago (2013-04-12 15:26:34 UTC) #4

Vyacheslav Egorov (Google)

7 years, 8 months ago (2013-04-12 15:28:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r21364 (presubmit successful).

Expand Messages | Collapse Messages