runtime/vm/intermediate_language.h - Issue 13884009: Support IfThenElse instruction pattern for arbitrary smi constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.h

Issue 13884009: Support IfThenElse instruction pattern for arbitrary smi constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.h

diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h

index 9ac45c16918933117c56e0a8724902d5175011fd..c80770c8d7b0365e53d57eef25d95b2cbfa931ce 100644

--- a/runtime/vm/intermediate_language.h

+++ b/runtime/vm/intermediate_language.h

@@ -2774,7 +2774,10 @@ class IfThenElseInstr : public TemplateDefinition<2> {

virtual bool HasSideEffect() const { return false; }

virtual bool AttributesEqual(Instruction* other) const {

- return kind_ == other->AsIfThenElse()->kind_;

+ IfThenElseInstr* other_if_then_else = other->AsIfThenElse();

+ return (kind_ == other_if_then_else->kind_) &&

+ (if_true_ == other_if_then_else->if_true_) &&

+ (if_false_ == other_if_then_else->if_false_);

}

virtual bool AffectedBySideEffect() const {

« no previous file with comments | « no previous file | runtime/vm/intermediate_language_ia32.cc » ('j') | tests/language/if_conversion_vm_test.dart » ('J')