Issue 13874008: Remove String.slice. Too much overlap with String.substring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13874008: Remove String.slice. Too much overlap with String.substring. (Closed)

Created:
7 years, 8 months ago by floitsch

Modified:
7 years, 8 months ago

Reviewers:
Lasse Reichstein Nielsen, Anders Johnsen

CC:
reviews_dartlang.org, Jennifer Messerly, Siggi Cherem (dart-lang), srdjan

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove String.slice. Too much overlap with String.substring. Committed: https://code.google.com/p/dart/source/detail?r=21442

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -183 lines)			Patch
M	runtime/lib/string_patch.dart	View	1	1 chunk	+0 lines, -35 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_string.dart	View		1 chunk	+0 lines, -36 lines	0 comments	Download
M	sdk/lib/core/string.dart	View		1 chunk	+0 lines, -16 lines	0 comments	Download
D	tests/corelib/string_slice_test.dart	View		1 chunk	+0 lines, -95 lines	0 comments	Download
M	tools/dom/docs/lib/docs.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

floitsch

7 years, 8 months ago (2013-04-15 12:20:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r21442 (presubmit successful).