Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: tools/dom/docs/lib/docs.dart

Issue 13874008: Remove String.slice. Too much overlap with String.substring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add VM changes. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/corelib/string_slice_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * A library for extracting the documentation from the various HTML libraries 6 * A library for extracting the documentation from the various HTML libraries
7 * ([dart:html], [dart:svg], [dart:web_audio], [dart:indexed_db]) and saving 7 * ([dart:html], [dart:svg], [dart:web_audio], [dart:indexed_db]) and saving
8 * those documentation comments to a JSON file. 8 * those documentation comments to a JSON file.
9 */ 9 */
10 10
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 classMirror.members.values.toList()); 99 classMirror.members.values.toList());
100 100
101 var membersJson = {}; 101 var membersJson = {};
102 for (var memberMirror in sortedMembers) { 102 for (var memberMirror in sortedMembers) {
103 var memberDomName = domNames(memberMirror)[0]; 103 var memberDomName = domNames(memberMirror)[0];
104 var memberComment = _splitCommentsByNewline( 104 var memberComment = _splitCommentsByNewline(
105 computeUntrimmedCommentAsList(memberMirror)); 105 computeUntrimmedCommentAsList(memberMirror));
106 106
107 // Remove interface name from Dom Name. 107 // Remove interface name from Dom Name.
108 if (memberDomName.indexOf('.') >= 0) { 108 if (memberDomName.indexOf('.') >= 0) {
109 memberDomName = memberDomName.slice(memberDomName.indexOf('.') + 1); 109 memberDomName =
110 memberDomName.substring(memberDomName.indexOf('.') + 1);
110 } 111 }
111 112
112 if (!memberComment.isEmpty) { 113 if (!memberComment.isEmpty) {
113 membersJson.putIfAbsent(memberDomName, () => memberComment); 114 membersJson.putIfAbsent(memberDomName, () => memberComment);
114 } 115 }
115 } 116 }
116 117
117 // Only include the comment if DocsEditable is set. 118 // Only include the comment if DocsEditable is set.
118 var classComment = _splitCommentsByNewline( 119 var classComment = _splitCommentsByNewline(
119 computeUntrimmedCommentAsList(classMirror)); 120 computeUntrimmedCommentAsList(classMirror));
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 for (var s in tags.reflectee.split(',')) { 184 for (var s in tags.reflectee.split(',')) {
184 domNames.add(s.trim()); 185 domNames.add(s.trim());
185 } 186 }
186 187
187 if (domNames.length == 1 && domNames[0] == 'none') return <String>[]; 188 if (domNames.length == 1 && domNames[0] == 'none') return <String>[];
188 return domNames; 189 return domNames;
189 } else { 190 } else {
190 return <String>[]; 191 return <String>[];
191 } 192 }
192 } 193 }
OLDNEW
« no previous file with comments | « tests/corelib/string_slice_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698