Issue 13872007: Refactor removeRange.

Issue 13872007: Refactor removeRange. (Closed)

Created:
7 years, 8 months ago by floitsch

Modified:
7 years, 8 months ago

Reviewers:
Lasse Reichstein Nielsen, blois

CC:
reviews_dartlang.org, srdjan, blois, Jennifer Messerly

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor removeRange. Committed: https://code.google.com/p/dart/source/detail?r=21462

Patch Set 3 : dart2js needs to check that list is mutable. #

Patch Set 5 : Update status files and rebuild dom (unrelated CL). #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -154 lines)			Patch
M	editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/lib/mock.dart	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/lib/array.dart	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1 2 3	1 chunk	+5 lines, -8 lines	0 comments	Download
M	runtime/lib/typeddata.dart	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/swarm/swarm_ui_lib/observable/observable.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_collection_dev/list.dart	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_array.dart	View	1 2 3	1 chunk	+9 lines, -17 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/src/markdown/inline_parser.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/collection/list.dart	View	1 2 3 4	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/core/list.dart	View	1 2 3	2 chunks	+6 lines, -9 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		36 chunks	+41 lines, -35 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		36 chunks	+41 lines, -35 lines	0 comments	Download
M	sdk/lib/html/html_common/filtered_element_list.dart	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/io/http_headers.dart	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1 2 3 4	6 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1 2 3 4	6 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/corelib/list_remove_range_test.dart	View		2 chunks	+7 lines, -11 lines	0 comments	Download
M	tools/dom/src/WrappedList.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/immutable_list_mixin.darttemplate	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://chromiumcodereview.appspot.com/13872007/diff/2001/pkg/unittest/lib/mock.dart File pkg/unittest/lib/mock.dart (right): https://chromiumcodereview.appspot.com/13872007/diff/2001/pkg/unittest/lib/mock.dart#newcode516 pkg/unittest/lib/mock.dart:516: int startIndex = i--; Just: i--; logs.removeRange(i, i ...

7 years, 8 months ago (2013-04-11 10:50:14 UTC) #2

floitsch

Rebase and small change in dart2js' library (check that the list can change its size).

7 years, 8 months ago (2013-04-11 16:21:23 UTC) #3

floitsch

7 years, 8 months ago (2013-04-15 15:10:53 UTC) #7

Message was sent while issue was closed.

Committed patchset #5 manually as r21462 (presubmit successful).

Expand Messages | Collapse Messages