Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1423)

Unified Diff: sdk/lib/core/list.dart

Issue 13872007: Refactor removeRange. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status files and rebuild dom (unrelated CL). Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/collection/list.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/core/list.dart
diff --git a/sdk/lib/core/list.dart b/sdk/lib/core/list.dart
index 470d8ce80171fd92ca0cfbf07b14d5cea7177ff5..d0442c0b0b44b6a338f8a2ab417815a877910554 100644
--- a/sdk/lib/core/list.dart
+++ b/sdk/lib/core/list.dart
@@ -264,7 +264,7 @@ abstract class List<E> implements Iterable<E> {
/**
* Copies the elements of [iterable], skipping the [skipCount] first elements
- * into the range [start] - [end] of `this`.
+ * into the range [start] - [end] (excluding) of `this`.
*
* If [start] equals [end] and represent a legal range, this method has
* no effect.
@@ -278,15 +278,12 @@ abstract class List<E> implements Iterable<E> {
void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]);
/**
- * Removes [length] elements from the list, beginning at [start].
- * Throws an [UnsupportedError] if the list is
- * not extendable.
- * If [length] is 0, this method does not do anything.
- * Throws an [ArgumentError] if [length] is negative.
- * Throws an [RangeError] if [start] or
- * [:start + length: - 1] are out of range.
+ * Removes the elements in the range [start]..[end] (excluding).
+ *
+ * It is an error if [start]..[end] is not a valid range pointing into the
+ * `this`.
*/
- void removeRange(int start, int length);
+ void removeRange(int start, int end);
/**
* Inserts a new range into the list, starting from [start] to
« no previous file with comments | « sdk/lib/collection/list.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698