Issue 13842019: - Check for error when creating the source string.

LGTM with a question. https://codereview.chromium.org/13842019/diff/1/runtime/bin/dartutils.cc File runtime/bin/dartutils.cc (right): https://codereview.chromium.org/13842019/diff/1/runtime/bin/dartutils.cc#newcode397 runtime/bin/dartutils.cc:397: return Dart_LoadScript(resolved_script_uri, source, 0, 0); ...

7 years, 8 months ago (2013-04-22 13:05:41 UTC) #2

Ivan Posva

https://codereview.chromium.org/13842019/diff/1/runtime/bin/dartutils.cc File runtime/bin/dartutils.cc (right): https://codereview.chromium.org/13842019/diff/1/runtime/bin/dartutils.cc#newcode397 runtime/bin/dartutils.cc:397: return Dart_LoadScript(resolved_script_uri, source, 0, 0); On 2013/04/22 13:05:41, Mads ...

7 years, 8 months ago (2013-04-22 13:12:42 UTC) #3

Ivan Posva

Committed patchset #1 manually as r21813 (presubmit successful).

7 years, 8 months ago (2013-04-22 13:13:05 UTC) #4

Mads Ager (google)

7 years, 8 months ago (2013-04-22 13:13:48 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/13842019/diff/1/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/13842019/diff/1/runtime/bin/dartutils.cc#newc...
runtime/bin/dartutils.cc:397: return Dart_LoadScript(resolved_script_uri,
source, 0, 0);
On 2013/04/22 13:12:42, Ivan Posva wrote:
> On 2013/04/22 13:05:41, Mads Ager wrote:
> > I thought all of the APIs had the property that they return an error is one
of
> > the arguments is an error. I believe that is the case with most of the other
> > APIs, should we make that the case for LoadScript as well?
> 
> Dart_LoadScript does return an error if it gets unexpected parameters, but at
> that point the more descriptive error you would get from
Dart_NewStringFromUTF8
> is discarded.

I see. Thanks! :)

Expand Messages | Collapse Messages