- Check for error when creating the source string.

runtime/bin/dartutils.cc

Index: runtime/bin/dartutils.cc
===================================================================
--- runtime/bin/dartutils.cc	(revision 21785)
+++ runtime/bin/dartutils.cc	(working copy)
@@ -391,6 +391,9 @@
     return Dart_LoadScriptFromSnapshot(text_buffer, len);
   } else {
     Dart_Handle source = Dart_NewStringFromUTF8(text_buffer, len);
+    if (Dart_IsError(source)) {
+      return source;
+    }
     return Dart_LoadScript(resolved_script_uri, source, 0, 0);

[Mads Ager (google), 2013/04/22 13:05:41]

I thought all of the APIs had the property that they return an error is one of
the arguments is an error. I believe that is the case with most of the other
APIs, should we make that the case for LoadScript as well?

[Ivan Posva, 2013/04/22 13:12:42]

Dart_LoadScript does return an error if it gets unexpected parameters, but at
that point the more descriptive error you would get from Dart_NewStringFromUTF8
is discarded.

[Mads Ager (google), 2013/04/22 13:13:48]

I see. Thanks! :)

   }
 }