Issue 138203003: Mark simd128_value_t as able to containing both float and int32_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138203003: Mark simd128_value_t as able to containing both float and int32_t. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen

Modified:
6 years, 10 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark simd128_value_t as able to containing both float and int32_t. This fixes a bug when compiled with MSVC, where some values (I suspect NANs) can be changed when passed to functions. BUG= R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=32121

Patch Set 1 #

Total comments: 2

Patch Set 2 : storage->float_storage #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -19 lines)			Patch
	M	runtime/platform/globals.h	View	1	2 chunks	+20 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

John, please let me know if this fix is an issue for you.

6 years, 10 months ago (2014-01-29 14:03:15 UTC) #1

kasperl

LGTM. https://codereview.chromium.org/138203003/diff/1/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/138203003/diff/1/runtime/platform/globals.h#newcode77 runtime/platform/globals.h:77: float storage[4]; Rename to float_storage?

6 years, 10 months ago (2014-01-29 14:07:50 UTC) #2

Anders Johnsen

https://codereview.chromium.org/138203003/diff/1/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/138203003/diff/1/runtime/platform/globals.h#newcode77 runtime/platform/globals.h:77: float storage[4]; On 2014/01/29 14:07:50, kasperl wrote: > Rename ...

6 years, 10 months ago (2014-01-29 14:21:20 UTC) #3

Anders Johnsen

6 years, 10 months ago (2014-01-29 14:22:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32121 (presubmit successful).

Expand Messages | Collapse Messages