Mark simd128_value_t as able to containing both float and int32_t.

runtime/platform/globals.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef PLATFORM_GLOBALS_H_
 #define PLATFORM_GLOBALS_H_
 
 // __STDC_FORMAT_MACROS has to be defined before including <inttypes.h> to
 // enable platform independent printf format specifiers.
 #ifndef __STDC_FORMAT_MACROS
@@ skipping 55 matching lines @@
 #define TARGET_OS_LINUX 1
 #elif defined(__APPLE__)
 #define TARGET_OS_MACOS 1
 #elif defined(_WIN32)
 #define TARGET_OS_WINDOWS 1
 #else
 #error Automatic target os detection failed.
 #endif
 
 struct simd128_value_t {
-  float storage[4];
+  union {
+    float storage[4];

[kasperl, 2014/01/29 14:07:50]

Rename to float_storage?

[Anders Johnsen, 2014/01/29 14:21:20]

Done.

+    int32_t int_storage[4];
+  };
   simd128_value_t& readFrom(const float* v) {
     storage[0] = v[0];
     storage[1] = v[1];
     storage[2] = v[2];
     storage[3] = v[3];
     return *this;
   }
   simd128_value_t& readFrom(const int32_t* v) {
-    const float* vv = reinterpret_cast<const float*>(v);
-    storage[0] = vv[0];
-    storage[1] = vv[1];
-    storage[2] = vv[2];
-    storage[3] = vv[3];
+    int_storage[0] = v[0];
+    int_storage[1] = v[1];
+    int_storage[2] = v[2];
+    int_storage[3] = v[3];
     return *this;
   }
   simd128_value_t& readFrom(const simd128_value_t* v) {
     *this = *v;
     return *this;
   }
   void writeTo(float* v) {
     v[0] = storage[0];
     v[1] = storage[1];
     v[2] = storage[2];
     v[3] = storage[3];
   }
   void writeTo(int32_t* v) {
-    float* vv = reinterpret_cast<float*>(v);
-    vv[0] = storage[0];
-    vv[1] = storage[1];
-    vv[2] = storage[2];
-    vv[3] = storage[3];
+    v[0] = int_storage[0];
+    v[1] = int_storage[1];
+    v[2] = int_storage[2];
+    v[3] = int_storage[3];
   }
   void writeTo(simd128_value_t* v) {
     *v = *this;
   }
 };
 
 // Processor architecture detection.  For more info on what's defined, see:
 //   http://msdn.microsoft.com/en-us/library/b0084kay.aspx
 //   http://www.agner.org/optimize/calling_conventions.pdf
 //   or with gcc, run: "echo | gcc -E -dM -"
@@ skipping 371 matching lines @@
 // N.B.: As the GCC manual states, "[s]ince non-static C++ methods
 // have an implicit 'this' argument, the arguments of such methods
 // should be counted from two, not one."
 #define PRINTF_ATTRIBUTE(string_index, first_to_check) \
   __attribute__((__format__(__printf__, string_index, first_to_check)))
 #else
 #define PRINTF_ATTRIBUTE(string_index, first_to_check)
 #endif
 
 #endif  // PLATFORM_GLOBALS_H_