Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1382023002: Support for --fatal-hints. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/analyzer_cli.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -17 lines) Patch
M lib/src/analyzer_impl.dart View 3 chunks +11 lines, -7 lines 0 comments Download
M lib/src/error_formatter.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/src/options.dart View 3 chunks +8 lines, -0 lines 0 comments Download
A test/data/file_with_error.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A test/data/file_with_hint.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A test/data/file_with_warning.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M test/driver_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
M test/options_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M test/reporter_test.dart View 5 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 2 months ago (2015-10-01 17:14:57 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-10-01 17:17:21 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as d3b33ce85e524868105f55b3a76154cc391e9408 (presubmit successful).
5 years, 2 months ago (2015-10-01 17:24:48 UTC) #4
Brian Wilkerson
5 years, 2 months ago (2015-10-01 17:38:03 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698