Support for --fatal-hints.

lib/src/analyzer_impl.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.src.analyzer_impl;
 
 import 'dart:collection';
 import 'dart:io';
 
 import 'package:analyzer/src/generated/element.dart';
@@ skipping 47 matching lines @@
       this.options, this.startTime);
 
   /// Returns the maximal [ErrorSeverity] of the recorded errors.
   ErrorSeverity get maxErrorSeverity {
     var status = ErrorSeverity.NONE;
     for (AnalysisErrorInfo errorInfo in errorInfos) {
       for (AnalysisError error in errorInfo.errors) {
         if (!_isDesiredError(error)) {
           continue;
         }
-        var severity = computeSeverity(error, options.enableTypeChecks);
+        var severity = computeSeverity(error, options);
         status = status.max(severity);
       }
     }
     return status;
   }
 
   void addCompilationUnitSource(CompilationUnitElement unit,
       Set<LibraryElement> libraries, Set<CompilationUnitElement> units) {
     if (unit == null || units.contains(unit)) {
       return;
@@ skipping 104 matching lines @@
     if (status == ErrorSeverity.WARNING && options.warningsAreFatal) {
       status = ErrorSeverity.ERROR;
     }
     return status;
   }
 
   bool _isDesiredError(AnalysisError error) {
     if (error.errorCode.type == ErrorType.TODO) {
       return false;
     }
-    if (computeSeverity(error, options.enableTypeChecks) ==
+    if (computeSeverity(error, options) ==
             ErrorSeverity.INFO &&
         options.disableHints) {
       return false;
     }
     return true;
   }
 
   /// Determine whether the given URI refers to a package other than the package
   /// being analyzed.
   bool _isOtherPackage(Uri uri) {
@@ skipping 31 matching lines @@
     // passed in from batch mode which removes the batch flag to prevent the
     // "cannot have the batch flag and source file" error message.
     StringSink sink = options.machineFormat ? errorSink : outSink;
 
     // Print errors.
     ErrorFormatter formatter =
         new ErrorFormatter(sink, options, _isDesiredError);
     formatter.formatErrors(errorInfos);
   }
 
-  /// Compute the severity of the error; however, if
-  /// [enableTypeChecks] is false, then de-escalate checked-mode compile time
-  /// errors to a severity of [ErrorSeverity.INFO].
+  /// Compute the severity of the error; however:
+  ///   * if [options.enableTypeChecks] is false, then de-escalate checked-mode
+  ///   compile time errors to a severity of [ErrorSeverity.INFO].
+  ///   * if [options.hintsAreFatal] is true, escalate hints to errors.
   static ErrorSeverity computeSeverity(
-      AnalysisError error, bool enableTypeChecks) {
-    if (!enableTypeChecks &&
+    AnalysisError error, CommandLineOptions options) {
+    if (!options.enableTypeChecks &&
         error.errorCode.type == ErrorType.CHECKED_MODE_COMPILE_TIME_ERROR) {
       return ErrorSeverity.INFO;
     }
+    if (options.hintsAreFatal && error.errorCode is HintCode) {
+      return ErrorSeverity.ERROR;
+    }
     return error.errorCode.errorSeverity;
   }
 
   /// Return the corresponding package directory or `null` if none is found.
   static JavaFile getPackageDirectoryFor(JavaFile sourceFile) {
     // We are going to ask parent file, so get absolute path.
     sourceFile = sourceFile.getAbsoluteFile();
     // Look in the containing directories.
     JavaFile dir = sourceFile.getParentFile();
     while (dir != null) {
@@ skipping 38 matching lines @@
   }
 
   @override
   void logInformation2(String message, Object exception) {
     outSink.writeln(message);
     if (exception != null) {
       outSink.writeln(exception.toString());
     }
   }
 }