Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1377453005: Cleanups and preemptively pass Heap::kOld whenever subtype testing in compiler (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanups and preemptively pass Heap::kOld whenever subtype testing in compiler BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/d867784de59338e82a0eef8ac89d2a7d7a17dd5f

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -28 lines) Patch
M runtime/vm/constant_propagator.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 2 months ago (2015-09-28 23:22:54 UTC) #2
regis
lgtm
5 years, 2 months ago (2015-09-28 23:40:08 UTC) #3
srdjan
5 years, 2 months ago (2015-09-29 18:06:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d867784de59338e82a0eef8ac89d2a7d7a17dd5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698