Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: runtime/vm/parser.cc

Issue 1377453005: Cleanups and preemptively pass Heap::kOld whenever subtype testing in compiler (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: sync Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 958167194b7e6e722479331982d1516136a6ca7f..a84b79e70108dcf106403a9c128c3de1881175eb 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -13167,7 +13167,7 @@ void Parser::ParseConstructorClosurization(Function* constructor,
ASSERT(!type.IsMalformedOrMalbounded());
if (!type.IsInstantiated()) {
Error& error = Error::Handle(Z);
- type ^= type.InstantiateFrom(*type_arguments, &error);
+ type ^= type.InstantiateFrom(*type_arguments, &error, NULL, Heap::kOld);
ASSERT(error.IsNull());
}
*type_arguments = type.arguments();
@@ -13371,7 +13371,8 @@ AstNode* Parser::ParseNewOperator(Token::Kind op_kind) {
}
return ThrowTypeError(redirect_type.token_pos(), redirect_type);
}
- if (I->flags().type_checks() && !redirect_type.IsSubtypeOf(type, NULL)) {
+ if (I->flags().type_checks() &&
+ !redirect_type.IsSubtypeOf(type, NULL, Heap::kOld)) {
// Additional type checking of the result is necessary.
type_bound = type.raw();
}
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698