Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1376143004: Fix build breakage encountered by Flutter (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix build breakage encountered by Flutter BUG= Committed: https://github.com/dart-lang/sdk/commit/4b4e836960dfc75f174084ec9233b4516569a38f

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/bin.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/bin/process.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
TBR
5 years, 2 months ago (2015-10-01 13:47:49 UTC) #2
Cutch
Committed patchset #3 (id:40001) manually as 4b4e836960dfc75f174084ec9233b4516569a38f (presubmit successful).
5 years, 2 months ago (2015-10-01 14:18:31 UTC) #3
zra
5 years, 2 months ago (2015-10-01 14:53:15 UTC) #4
Message was sent while issue was closed.
There is probably a cleaner way to break this dependency, but since this will
only be in for a couple weeks:

lgtm

Powered by Google App Engine
This is Rietveld 408576698