Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: runtime/bin/process.cc

Issue 1376143004: Fix build breakage encountered by Flutter (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/bin.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process.cc
diff --git a/runtime/bin/process.cc b/runtime/bin/process.cc
index 9e3e14e7ae5d7f164e155bdf61dad7cfaaf90d04..47e2ff58c473f86dc73e1c923359c0972662844a 100644
--- a/runtime/bin/process.cc
+++ b/runtime/bin/process.cc
@@ -262,7 +262,15 @@ void FUNCTION_NAME(Process_Exit)(Dart_NativeArguments args) {
free(error);
}
if (do_vm_shutdown) {
+#ifdef LEGACY_DEBUG_PROTOCOL_ENABLED
+ // Note that this dependency crosses logical project boundaries by making
+ // the dart:io implementation depend upon the standalone VM's legacy debug
+ // protocol. This breaks projects which want to use our dart:io
+ // implementation. Because the protocol is going away shortly, it's
+ // reasonable to leave it behind a #ifdef that is only enabled for the
+ // standalone VM for now.
DebuggerConnectionHandler::StopHandler();
+#endif
EventHandler::Stop();
}
exit(static_cast<int>(status));
« no previous file with comments | « runtime/bin/bin.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698