Add more timing information in the VM to track time spent is dart code Vs native code.

Add more timing information in the VM to track time spent is dart code Vs native code.

R=johnmccutchan@google.com, turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32930

[turnidge, 2014-02-11 21:24:33]

https://codereview.chromium.org/137483010/diff/190003/runtime/vm/dart_api_impl.h
File runtime/vm/dart_api_impl.h (right):

https://codereview.chromium.org/137483010/diff/190003/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.h:297: }
Is it ever the case that neither timer is running here?

https://codereview.chromium.org/137483010/diff/190003/runtime/vm/native_argum...
File runtime/vm/native_arguments.h (right):

https://codereview.chromium.org/137483010/diff/190003/runtime/vm/native_argum...
runtime/vm/native_arguments.h:224: class DartToNativeTimerScope : public
ValueObject {
Two notes:

1) Did you consider putting all of these timer scope objects in timer.h?

Also...

2) 

If we had the TimerList object keep track of which Timer is currently active,
then we could just have a single TimerScope class.   Here's a cruddy
implementation for discussion:

  explicit TimerScope(Isolate* isolate, Timer* timer) : isolate_(isolate) {
    saved_timer_ = isolate->timer_list()->active_timer();
    isolate->timer_list()->activate(timer);  // deactivates current.  timer may
be NULL.
  }

  ~TimerScope() {
    isolate_->timer_list()->activate(saved_timer_);
  }

There would be the odd case that the total timer is special, etc.  I'm not
saying to do this, just asking if you've thought about it.

[turnidge, 2014-02-11 21:53:14]

lgtm

[siva, 2014-02-19 22:38:29]

Addressed comments, PTAL.

https://codereview.chromium.org/137483010/diff/190003/runtime/vm/dart_api_impl.h
File runtime/vm/dart_api_impl.h (right):

https://codereview.chromium.org/137483010/diff/190003/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.h:297: }
Changed the code to have just
if (dart_timer->running()) {
 ....
 ....
} else {
 native_timer->Stop();
}

This ensures that in this transition only Dart or Native code is executing.

On 2014/02/11 21:24:33, turnidge wrote:
> Is it ever the case that neither timer is running here?

https://codereview.chromium.org/137483010/diff/190003/runtime/vm/native_argum...
File runtime/vm/native_arguments.h (right):

https://codereview.chromium.org/137483010/diff/190003/runtime/vm/native_argum...
runtime/vm/native_arguments.h:224: class DartToNativeTimerScope : public
ValueObject {
On 2014/02/11 21:24:33, turnidge wrote:
> Two notes:
> 
> 1) Did you consider putting all of these timer scope objects in timer.h?


Created a new file timer_scope.h and moved all the Scopes over to this file.

> 
> Also...
> 
> 2) 
> 
> If we had the TimerList object keep track of which Timer is currently active,
> then we could just have a single TimerScope class.   Here's a cruddy
> implementation for discussion:
> 
>   explicit TimerScope(Isolate* isolate, Timer* timer) : isolate_(isolate) {
>     saved_timer_ = isolate->timer_list()->active_timer();
>     isolate->timer_list()->activate(timer);  // deactivates current.  timer
may
> be NULL.
>   }
> 
>   ~TimerScope() {
>     isolate_->timer_list()->activate(saved_timer_);
>   }
> 
> There would be the odd case that the total timer is special, etc.  I'm not
> saying to do this, just asking if you've thought about it.

As discussed offline we have some overlapping timers and it makes one scope
object mutually excluding timers can be difficult, we could maybe as this
stabilizes move towards having one common execution timer scope which
transitions dart/native and vm execution states.

[Cutch, 2014-02-21 21:17:49]

lgtm

[siva, 2014-02-21 21:30:44]

Committed patchset #8 manually as r32930 (presubmit successful).