Issue 13726010: Rename context2d to context2D.

Issue 13726010: Rename context2d to context2D. (Closed)

Created:
7 years, 8 months ago by Emily Fortuna

Modified:
7 years, 8 months ago

Reviewers:
Andrei Mouravski, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename context2d to context2D. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21006

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -35 lines)			Patch
M	runtime/bin/vmstats/bargraph.dart	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	samples/solar/web/solar.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/spirodraw/web/colorpicker.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/spirodraw/web/spirodraw.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	samples/sunflower/web/sunflower.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		7 chunks	+11 lines, -7 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		7 chunks	+11 lines, -7 lines	0 comments	Download
M	tests/html/canvas_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/canvasrenderingcontext2d_test.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/url_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/docs/docs.json	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

blois

I imagine some tests need changes too. https://codereview.chromium.org/13726010/diff/1004/tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate File tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate (right): https://codereview.chromium.org/13726010/diff/1004/tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate#newcode14 tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate:14: gl.RenderingContext getContext3d({alpha: ...

7 years, 8 months ago (2013-04-05 17:15:38 UTC) #2

Andrei Mouravski

Also, make sure to grep (or Ag: https://github.com/ggreer/the_silver_searcher) through all the other folders for this ...

7 years, 8 months ago (2013-04-05 17:57:53 UTC) #3

Andrei Mouravski

Also, make sure to grep (or Ag: https://github.com/ggreer/the_silver_searcher) through all the other folders for this ...

7 years, 8 months ago (2013-04-05 17:57:54 UTC) #4

Andrei Mouravski

lgtm https://codereview.chromium.org/13726010/diff/2002/tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate File tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate (right): https://codereview.chromium.org/13726010/diff/2002/tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate#newcode9 tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate:9: /** Accessor to the drawing API on canvas. ...

7 years, 8 months ago (2013-04-05 22:31:21 UTC) #6

blois

lgtm https://codereview.chromium.org/13726010/diff/2002/tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate File tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate (right): https://codereview.chromium.org/13726010/diff/2002/tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate#newcode10 tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate:10: CanvasRenderingContext2D get context2D => getContext('2d'); Might be kind ...

7 years, 8 months ago (2013-04-05 22:35:56 UTC) #7

Emily Fortuna

7 years, 8 months ago (2013-04-05 23:16:57 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r21006 (presubmit successful).

Expand Messages | Collapse Messages