Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 13724021: Remove deprecated Expect from the libraries. (Closed)

Created:
7 years, 8 months ago by floitsch
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Remove deprecated Expect from the libraries. Committed: https://code.google.com/p/dart/source/detail?r=21079

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments. Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -341 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 1 7 chunks +43 lines, -4 lines 0 comments Download
M sdk/lib/core/core.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/core/corelib_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/core/expect.dart View 1 chunk +0 lines, -318 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +44 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/corelib/double_ceil2_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_ceil_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_ceil_to_double_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_floor2_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_floor_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_floor_to_double_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_round2_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_round3_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_round4_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_round_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_round_to_double2_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_round_to_double3_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_round_to_double_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_truncate2_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_truncate_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/double_truncate_to_double_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/int_ceil_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/int_ceil_to_double_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/int_floor_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/int_floor_to_double_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/int_round_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/int_round_to_double_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/int_to_int_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/int_truncate_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/int_truncate_to_double_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/iterable_first_where_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/iterable_last_where_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/iterable_single_where_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/list_insert_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/isolate/global_error_handler2_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/isolate/global_error_handler_stream2_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/isolate/illegal_msg_stream_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/argument_definition6_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/call_property_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/closure_type_variable_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/constructor_initializer_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/deopt_hoisted_smi_check_vm_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/duplicate_interface_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/factory_type_parameter2_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/getter_setter_order_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/identical_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/inline_super_field_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/inlined_throw_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/interceptor7_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/mixin_field_initializer_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/mixin_lib_extends_field_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/operator_equals_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/private_mixin2_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/super_getter_setter_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/super_operator_index7_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/type_variable_nested_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/value_range3_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/async/run_async2_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/async/run_async5_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/async/timer_not_available_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/typeddata/float32x4_list_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/typeddata/float32x4_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/byte_array_view_optimized_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_read_special_device_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/file_read_stdio_script.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/io/file_system_delete_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/file_system_exists_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_compression_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_proxy_configuration_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/link_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/regress_9194_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/sleep_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/stdout_stderr_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 2 chunks +11 lines, -4 lines 0 comments Download
M tests/standalone/status_expression_test.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tests/standalone/typed_data_view_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/status_expression.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 5 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
floitsch
Mostly adding import "package:expect/expect.dart" to the test-files. The exceptions are: runtime/vm/dart_api_impl_test.cc tests/standalone/debugger/debug_lib.dart tests/standalone/io/file_read_stdio_script.dart tests/standalone/io/test_runner_test.dart tools/testing/dart/test_runner.dart ...
7 years, 8 months ago (2013-04-05 23:34:45 UTC) #1
kustermann
lgtm
7 years, 8 months ago (2013-04-06 14:21:10 UTC) #2
Lasse Reichstein Nielsen
LGTM, but remove the Exception's. https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/debug_lib.dart File tests/standalone/debugger/debug_lib.dart (right): https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/debug_lib.dart#newcode458 tests/standalone/debugger/debug_lib.dart:458: if (errorsDetected) throw new ...
7 years, 8 months ago (2013-04-08 11:27:49 UTC) #3
floitsch
https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/debug_lib.dart File tests/standalone/debugger/debug_lib.dart (right): https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/debug_lib.dart#newcode458 tests/standalone/debugger/debug_lib.dart:458: if (errorsDetected) throw new Exception("Errors detected"); On 2013/04/08 11:27:49, ...
7 years, 8 months ago (2013-04-08 12:06:47 UTC) #4
floitsch
https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/debug_lib.dart File tests/standalone/debugger/debug_lib.dart (right): https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/debug_lib.dart#newcode458 tests/standalone/debugger/debug_lib.dart:458: if (errorsDetected) throw new Exception("Errors detected"); On 2013/04/08 12:06:47, ...
7 years, 8 months ago (2013-04-08 16:06:59 UTC) #5
floitsch
Committed patchset #2 manually as r21079 (presubmit successful).
7 years, 8 months ago (2013-04-08 16:08:46 UTC) #6
srdjan
7 years, 8 months ago (2013-04-08 16:36:49 UTC) #7
Message was sent while issue was closed.
LGTM

It would be good if the co19 tests could be updated ASAP, otherwise it seems
that we have quite a testing gap. (CC-d Peter).

Powered by Google App Engine
This is Rietveld 408576698