Issue 13723002: dart2js: Fix SSA corner case with always breaking loop and failing assert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13723002: dart2js: Fix SSA corner case with always breaking loop and failing assert (Closed)

Created:
7 years, 8 months ago by erikcorry

Modified:
7 years, 8 months ago

Reviewers:
Johnni Winther, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2js: Fix SSA corner case with always breaking loop and failing assert R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=20965

Patch Set 1 #

Total comments: 3

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+328 lines, -76 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	18 chunks	+108 lines, -76 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/validate.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/inlined_throw_test.dart	View	1 chunk	+200 lines, -0 lines	1 comment	Download
A	tests/language/unconditional_break.dart	View	1 chunk	+16 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

erikcorry

Committed patchset #1 manually as r20965 (presubmit successful).

7 years, 8 months ago (2013-04-05 13:06:17 UTC) #3

ngeoffray

7 years, 8 months ago (2013-04-07 09:48:50 UTC) #4

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/13723002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/13723002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4907: void
visitThrow(Node node) {
Why is that restriction not removed? Is that not what inlined_throw_test checks?

https://codereview.chromium.org/13723002/diff/1/tests/language/inlined_throw_...
File tests/language/inlined_throw_test.dart (right):

https://codereview.chromium.org/13723002/diff/1/tests/language/inlined_throw_...
tests/language/inlined_throw_test.dart:5: // Dart test program to test check
that we don't fail to compile when an
test check -> check

https://codereview.chromium.org/13723002/diff/1/tests/language/unconditional_...
File tests/language/unconditional_break.dart (right):

https://codereview.chromium.org/13723002/diff/1/tests/language/unconditional_...
tests/language/unconditional_break.dart:5: // Test to ensure that we get don't
exceptions in the SSA verifier when
get don't -> don't get

Expand Messages | Collapse Messages