sdk/lib/_internal/compiler/implementation/ssa/nodes.dart - Issue 13723002: dart2js: Fix SSA corner case with always breaking loop and failing assert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 13723002: dart2js: Fix SSA corner case with always breaking loop and failing assert (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/validate.dart » ('j') | tests/language/inlined_throw_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

index e6cfe3cd82b92d74668a8666a8cbe2109179a262..c1b9796ec9cbe58f70e8ea5889df11e536d25935 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

@@ -544,6 +544,8 @@ class HBasicBlock extends HInstructionList {

}

void addPhi(HPhi phi) {

+ assert(phi.inputs.length == 0 || phi.inputs.length == predecessors.length);

+ assert(phi.block == null);

phis.internalAddAfter(phis.last, phi);

phi.notifyAddedToBlock(this);

}

@@ -1931,6 +1933,7 @@ class HPhi extends HInstruction {

void addInput(HInstruction input) {

assert(isInBasicBlock());

inputs.add(input);

+ assert(inputs.length <= block.predecessors.length);

input.usedBy.add(this);

}