Fix dependencies of apidoc.

Fix dependencies of apidoc.

Committed: https://code.google.com/p/dart/source/detail?r=21058

[Andrei Mouravski, 2013-04-05 19:13:50]

https://codereview.chromium.org/13722007/diff/1/dart/utils/apidoc/apidoc.gyp
File dart/utils/apidoc/apidoc.gyp (right):

https://codereview.chromium.org/13722007/diff/1/dart/utils/apidoc/apidoc.gyp#...
dart/utils/apidoc/apidoc.gyp:35: '<!@(["python", "../../tools/list_files.py",
"\\.dart$", ".", "../../sdk/lib", "../../runtime/lib", "../../runtime/bin"])',
Please add documentation to this block or directly above 'inputs' describing
exactly what is happening.

[ahe, 2013-04-05 19:26:45]

https://codereview.chromium.org/13722007/diff/1/dart/utils/apidoc/apidoc.gyp
File dart/utils/apidoc/apidoc.gyp (right):

https://codereview.chromium.org/13722007/diff/1/dart/utils/apidoc/apidoc.gyp#...
dart/utils/apidoc/apidoc.gyp:35: '<!@(["python", "../../tools/list_files.py",
"\\.dart$", ".", "../../sdk/lib", "../../runtime/lib", "../../runtime/bin"])',
On 2013/04/05 19:13:50, Andrei Mouravski wrote:
> Please add documentation to this block or directly above 'inputs' describing
> exactly what is happening.

Will do.  Let me know if this answers your questions:

The 'inputs' list records the files whose timestamps are compared to the files
listed in 'outputs'.  If a file 'outputs' doesn't exist or if a file in 'inputs'
is newer than a file in 'outputs', this action is executed.  Notice that the
dependencies listed above has nothing to do with when this action is executed. 
You must list a file in 'inputs' to make sure that it exists before the action
is executed, or to make sure this action is re-run.

We want to build the platform documentation whenever dartdoc, apidoc, or its
dependency changes.  This prevents people from accidentally breaking apidoc when
making changes to the platform libraries and or when modifying dart2js or the
VM.

In addition, we want to make sure that the platform documentation is regenerated
when the platform sources changes.

So we want this action to be re-run when a dart file changes in this directory,
or in the SDK library (we may no longer need to list the files in
../../runtime/lib and ../../runtime/bin, as most of them has moved to
../../sdk/lib).

In addition, we want to make sure the documentation is regenerated when a
resource file (CSS, PNG, etc) is updated.  This is because these files are also
copied to the output directory.

[Andrei Mouravski, 2013-04-05 22:40:18]

lgtm

https://codereview.chromium.org/13722007/diff/1/dart/utils/apidoc/apidoc.gyp
File dart/utils/apidoc/apidoc.gyp (right):

https://codereview.chromium.org/13722007/diff/1/dart/utils/apidoc/apidoc.gyp#...
dart/utils/apidoc/apidoc.gyp:35: '<!@(["python", "../../tools/list_files.py",
"\\.dart$", ".", "../../sdk/lib", "../../runtime/lib", "../../runtime/bin"])',
On 2013/04/05 19:26:45, ahe wrote:
> On 2013/04/05 19:13:50, Andrei Mouravski wrote:
> > Please add documentation to this block or directly above 'inputs' describing
> > exactly what is happening.
> 
> Will do.  Let me know if this answers your questions:
> 
> The 'inputs' list records the files whose timestamps are compared to the files
> listed in 'outputs'.  If a file 'outputs' doesn't exist or if a file in
'inputs'
> is newer than a file in 'outputs', this action is executed.  Notice that the
> dependencies listed above has nothing to do with when this action is executed.

> You must list a file in 'inputs' to make sure that it exists before the action
> is executed, or to make sure this action is re-run.
> 
> We want to build the platform documentation whenever dartdoc, apidoc, or its
> dependency changes.  This prevents people from accidentally breaking apidoc
when
> making changes to the platform libraries and or when modifying dart2js or the
> VM.
> 
> In addition, we want to make sure that the platform documentation is
regenerated
> when the platform sources changes.
> 
> So we want this action to be re-run when a dart file changes in this
directory,
> or in the SDK library (we may no longer need to list the files in
> ../../runtime/lib and ../../runtime/bin, as most of them has moved to
> ../../sdk/lib).
> 
> In addition, we want to make sure the documentation is regenerated when a
> resource file (CSS, PNG, etc) is updated.  This is because these files are
also
> copied to the output directory.

I think for the time being, you could just copy this verbatim in here.

I would very much like all gyp files in the gyp directory and have a README in
there about how to properly write Dart gyp files.

That is not necessary right now, but would really help.

[kustermann, 2013-04-06 15:23:59]

lgtm

[ahe, 2013-04-08 10:49:18]

Committed patchset #2 manually as r21058 (presubmit successful).

[Andrei Mouravski, 2013-04-08 15:10:15]

On 2013/04/08 10:49:18, ahe wrote:
> Committed patchset #2 manually as r21058 (presubmit successful).

Thanks, Peter, for adding that text in there. :]